Add directory paging for rendering code trees

custom/conf/app.example.ini

@@ -1011,6 +1011,9 @@ PATH =
 ;; Number of issues that are displayed on one page
 ;ISSUE_PAGING_NUM = 10
 ;;
+;; Number of entries are displayed on code rendering page
+;DIRECTORY_PAGING_NUM = 50
+;;
 ;; Number of maximum commits displayed in one activity feed
 ;FEED_MAX_COMMIT_NUM = 5
 ;;

docs/content/doc/advanced/config-cheat-sheet.en-us.md

@@ -169,6 +169,7 @@ The following configuration set `Content-Type: application/vnd.android.package-a
 - `EXPLORE_PAGING_NUM`: **20**: Number of repositories that are shown in one explore page.
 - `ISSUE_PAGING_NUM`: **10**: Number of issues that are shown in one page (for all pages that list issues).
 - `MEMBERS_PAGING_NUM`: **20**: Number of members that are shown in organization members.
+- `DIRECTORY_PAGING_NUM`: **50**: Number of directory entries that are shown in one page.
 - `FEED_MAX_COMMIT_NUM`: **5**: Number of maximum commits shown in one activity feed.
 - `FEED_PAGING_NUM`: **20**: Number of items that are displayed in home feed.
 - `GRAPH_MAX_COMMIT_NUM`: **100**: Number of maximum commits shown in the commit graph.

modules/setting/setting.go

@@ -196,6 +196,7 @@ var (
 		IssuePagingNum        int
 		RepoSearchPagingNum   int
 		MembersPagingNum      int
+		DirectoryPagingNum    int
 		FeedMaxCommitNum      int
 		FeedPagingNum         int
 		GraphMaxCommitNum     int
@@ -248,6 +249,7 @@ var (
 		IssuePagingNum:      10,
 		RepoSearchPagingNum: 10,
 		MembersPagingNum:    20,
+		DirectoryPagingNum:  50,
 		FeedMaxCommitNum:    5,
 		FeedPagingNum:       20,
 		GraphMaxCommitNum:   100,

modules/util/paginate.go

@@ -18,17 +18,16 @@ func PaginateSlice(list interface{}, page, pageSize int) interface{} {
 
 	listValue := reflect.ValueOf(list)
 
-	page--
+	first := (page - 1) * pageSize
+	length := listValue.Len()
 
-	if page*pageSize >= listValue.Len() {
-		return listValue.Slice(listValue.Len(), listValue.Len()).Interface()
+	if first >= length {
+		return listValue.Slice(length, length).Interface()
 	}
 
-	listValue = listValue.Slice(page*pageSize, listValue.Len())
-
-	if listValue.Len() > pageSize {
-		return listValue.Slice(0, pageSize).Interface()
+	if first+pageSize >= length {
+		return listValue.Slice(first, length).Interface()
 	}
 
-	return listValue.Interface()
+	return listValue.Slice(first, first+pageSize).Interface()
 }

routers/web/repo/view.go

@@ -31,6 +31,7 @@ import (
 	"code.gitea.io/gitea/modules/setting"
 	"code.gitea.io/gitea/modules/structs"
 	"code.gitea.io/gitea/modules/typesniffer"
+	"code.gitea.io/gitea/modules/util"
 )
 
 const (
@@ -141,17 +142,7 @@ func renderDirectory(ctx *context.Context, treeLink string) {
 	}
 	entries.CustomSort(base.NaturalSortLess)
 
-	var c *git.LastCommitCache
-	if setting.CacheService.LastCommit.Enabled && ctx.Repo.CommitsCount >= setting.CacheService.LastCommit.CommitsCount {
-		c = git.NewLastCommitCache(ctx.Repo.Repository.FullName(), ctx.Repo.GitRepo, setting.LastCommitCacheTTLSeconds, cache.GetCache())
-	}
-
-	var latestCommit *git.Commit
-	ctx.Data["Files"], latestCommit, err = entries.GetCommitsInfo(ctx, ctx.Repo.Commit, ctx.Repo.TreePath, c)
-	if err != nil {
-		ctx.ServerError("GetCommitsInfo", err)
-		return
-	}
+	// First of all look for a README and docs directories
 
 	// 3 for the extensions in exts[] in order
 	// the last one is for a readme that doesn't
@@ -232,6 +223,35 @@ func renderDirectory(ctx *context.Context, treeLink string) {
 		}
 	}
 
+	// Now limit the number of directory items to the page
+	page := ctx.FormInt("page")
+	if page < 1 {
+		page = 1
+	}
+	pageSize := setting.UI.DirectoryPagingNum
+
+	if pageSize > 1 {
+		pager := context.NewPagination(len(entries), pageSize, page, 5)
+
+		ctx.Data["Page"] = pager
+
+		entries = util.PaginateSlice(entries, page, pageSize).(git.Entries)
+	}
+
+	// Find the last commits for the entries
+	var c *git.LastCommitCache
+	if setting.CacheService.LastCommit.Enabled && ctx.Repo.CommitsCount >= setting.CacheService.LastCommit.CommitsCount {
+		c = git.NewLastCommitCache(ctx.Repo.Repository.FullName(), ctx.Repo.GitRepo, setting.LastCommitCacheTTLSeconds, cache.GetCache())
+	}
+
+	var latestCommit *git.Commit
+	ctx.Data["Files"], latestCommit, err = entries.GetCommitsInfo(ctx, ctx.Repo.Commit, ctx.Repo.TreePath, c)
+	if err != nil {
+		ctx.ServerError("GetCommitsInfo", err)
+		return
+	}
+
+	// If we haven't found a readme file and we're in the root try the docs directories
 	if ctx.Repo.TreePath == "" && readmeFile == nil {
 		for _, entry := range docsEntries {
 			if entry == nil {
@@ -250,6 +270,7 @@ func renderDirectory(ctx *context.Context, treeLink string) {
 		}
 	}
 
+	// If there's a readme file render it
 	if readmeFile != nil {
 		ctx.Data["RawFileLink"] = ""
 		ctx.Data["ReadmeInList"] = true

templates/repo/view_list.tmpl

@@ -83,6 +83,9 @@
 		{{end}}
 	</tbody>
 </table>
+{{if .Page}}
+	{{ template "base/paginate" . }}
+{{end}}
 {{if .ReadmeExist}}
 	{{template "repo/view_file" .}}
 {{end}}

web_src/less/_repository.less

@@ -2524,6 +2524,11 @@
   padding-top: 15px;
 }
 
+.repository.file.list .page.buttons {
+  padding-top: 0;
+  margin-bottom: 1em;
+}
+
 .settings {
   .content {
     margin-top: 2px;