bug fixed for API to get user's repos #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tboerger
added
the
lgtm/need 2
cez81
reviewed
Apr 27, 2017
| @@ -9,7 +9,7 @@ import ( | |||
| // listUserRepos - List the repositories owned by the given user. | |||
| func listUserRepos(ctx *context.APIContext, u *models.User) { | |||
| userID := u.ID | |||
| showPrivateRepos := (ctx.User.ID == userID || ctx.User.IsAdmin) && ctx.IsSigned | |||
| showPrivateRepos := ctx.IsSigned && (ctx.User.ID == userID || ctx.User.IsAdmin) | |||
There was a problem hiding this comment.
ctx.User is also used in getAccessibleReposcalled from https://github.com/lunny/gitea/blob/07ad1e27dd8fbebb90b53590a958115e7c680130/routers/api/v1/user/repo.go#L18
|
For testing you can make integration test and request the API directly ? |
tboerger
added
lgtm/need 1
|
@lunny Perfect. Still LGTM for me ^^ |
|
LGTM |
tboerger
added
lgtm/done
sapk
reviewed
Apr 27, 2017
integrations/api_repo_test.go
Outdated
| func TestAPIUserReposNotLogin(t *testing.T) { | ||
| assert.NoError(t, models.LoadFixtures()) | ||
|
|
||
| req, err := http.NewRequest("GET", "/api/v1/users/user1/repos", nil) |
There was a problem hiding this comment.
user1 don't have repos in mock value so maybe we could also test user2 repo listing?
https://github.com/go-gitea/gitea/blob/master/models/fixtures/repository.yml
|
waiting for #1627 |
lunny
force-pushed
the
lunny/fix_api_user_repos
branch
from
80ad764
to
8bb4a20
Compare
|
let L-G-T-M work |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Will fix #1540. And how to test APIs? Maybe we need a framework like intergration test to do that?