feature: custom repo buttons #15532
feature: custom repo buttons #15532
Conversation
which is similar to Sponsor in github, and user can use it to do other things they like also :) limit the buttons number to 3, because too many buttons will break header ui. Signed-off-by: a1012112796 <1012112796@qq.com>
a1012112796
added
the
type/feature
Codecov Report
@@ Coverage Diff @@
## master #15532 +/- ##
==========================================
- Coverage 43.93% 43.90% -0.03%
==========================================
Files 678 678
Lines 81742 81795 +53
==========================================
+ Hits 35911 35915 +4
- Misses 39980 40021 +41
- Partials 5851 5859 +8
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
|
||
| const $detailModal = $('#detail-modal'); | ||
|
|
||
| $('.show-repo-button-content').on('click', function () { |
There was a problem hiding this comment.
I think this would be a good case for @silverwind's jsx PR, as I am concerned with the below line of injecting HTML and it creating an XSS issue.
There was a problem hiding this comment.
Probably not suitable. JSX is when you want to create a DOM structure completely in JS but in this case, it's some pre-rendered Markdown from the server. Generally I don't like putting HTML into data attributes, maybe it could be rendered directly but hidden via CSS, thought if this is just a dialog, that may already work without any JS involved.
There was a problem hiding this comment.
@silverwind How about current way? Thanks
|
In you screenshot, the buttons are missing their left border. Something funky going on with fomantic styles? Oh, and please match button height to the other buttons. |
|
I would prefer a dedicated feature for funding. I like how GitHub shows it now on the bottom of issues.
The users should fund free software! |
|
A hint about "wonder why centering ...": I also meet this problem and because the CSS is polluted globally. I have to bypass it by using
|
which is similar to Sponsor in github, and user can use it to do other things they like also :)
limit the buttons number to 3, because too many buttons will break header ui.
example view:
TODO：