Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the v176 migration #15110

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Fix the v176 migration #15110

merged 1 commit into from
Mar 22, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 22, 2021 •
edited by 6543
Loading

introduced by #14912

There is a serious issue with the v176 migration where there is a mistaken missing
label_id selection.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix the v176 migration
8e8bf9b 
There is a serious issue with the v176 migration where there is a mistaken missing
label_id selection.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Mar 22, 2021
@zeripath zeripath added this to the 1.15.0 milestone Mar 22, 2021
zeripath added a commit to zeripath/gitea that referenced this pull request Mar 22, 2021
@zeripath
Fix the v176 migration (go-gitea#15110)
bc4bbc4 
Backport go-gitea#15110

There is a serious issue with the v176 migration where there is a mistaken missing
label_id selection.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Mar 22, 2021
Merged
6543
6543 approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uff - sorry for overlooking in previous review!!

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 22, 2021
noerw
noerw approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@noerw noerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this didn't match any labels for my instance now

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2021
@6543 6543 merged commit dfb3e50 into go-gitea:master Mar 22, 2021
@zeripath zeripath deleted the fix-v176-incorrect-sql branch March 22, 2021 18:31
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 22, 2021
techknowlogick pushed a commit that referenced this pull request Mar 22, 2021
@zeripath
Fix the v176 migration (#15110) (#15111)
14011d7 
Backport #15110

There is a serious issue with the v176 migration where there is a mistaken missing
label_id selection.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Mar 23, 2021
Merged
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @noerw @6543 @GiteaBot