Fix issue search with db indexer because of mysql 5.7 sqlmode #14907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
skip-changelog
zeripath
approved these changes
Mar 6, 2021
GiteaBot
added
the
lgtm/need 1
|
Actually that appears to break tests |
6543
approved these changes
Mar 6, 2021
GiteaBot
added
lgtm/done
6543
approved these changes
Mar 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14905 caused by #14353.
Sinceidinissuetable is a primary key,distinctis unnecessary. Change that toSelectshould resolve the problem.UPDATE: Distinct is necessary, so I added updated_unix on select columns and then convert it to id slice.