Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to close related PRs when deleting a non-fork repository #14777

Closed
wants to merge 1 commit into from
Closed

Don't try to close related PRs when deleting a non-fork repository #14777

wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 22, 2021 •
edited
Loading

Fix #14775

@6543 6543 added this to the 1.14.0 milestone Feb 23, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 23, 2021
@zeripath
Copy link
Contributor

Hmm actually thinking on...

What do you mean you received lots of emails?

What kind of emails?

Are you fixing this at the right level?

zeripath
zeripath suggested changes Feb 27, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm thinking on I don't think this is correct

@zeripath
Copy link
Contributor

I think #14823 is more likely to be the correct thing.

@noerw noerw mentioned this pull request Feb 28, 2021
Merged
@6543
Copy link
Member

6543 commented Mar 1, 2021

#14823 got merged ...

@6543 6543 closed this Mar 1, 2021
@lunny lunny deleted the lunny/fix_repo_delete_notify branch March 2, 2021 13:44
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath requested changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Delete repository don't send issues notifications
4 participants
@lunny @zeripath @6543 @GiteaBot