Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow org labels to be set with issue templates #14593

Merged
merged 3 commits into from
Feb 10, 2021
Merged

Allow org labels to be set with issue templates #14593

merged 3 commits into from
Feb 10, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 7, 2021

Fix #13688

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Allow org labels to be set with issue templates
e78bd0a 
Fix go-gitea#13688

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Feb 7, 2021
@lunny lunny mentioned this pull request Feb 8, 2021
Closed
4 tasks
@jolheiser
Copy link
Member

At some point in a loop right below your changes, there is repoLabel.IsChecked = true which, if I remember correctly, was needed for something to display correctly.

I haven't had a chance to check this patch, but can you confirm it wasn't needed?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2021
@zeripath
Copy link
Contributor Author

zeripath commented Feb 8, 2021

At some point in a loop right below your changes, there is repoLabel.IsChecked = true which, if I remember correctly, was needed for something to display correctly.

I haven't had a chance to check this patch, but can you confirm it wasn't needed?

It's still there, line 757:

							repoLabel.IsChecked = true

This will still affect the repoLables passed on line 746, as the signature of GetLabelsByRepoID is:

func GetLabelsByRepoID(repoID int64, sortType string, listOptions ListOptions) ([]*Label, error)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 9, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2021
@zeripath zeripath merged commit 4cffc46 into go-gitea:master Feb 10, 2021
@zeripath zeripath deleted the fix-13688-issue-template-org-labels branch February 10, 2021 17:18
@richmahn
Copy link
Contributor

@zeripath is there a backport to v1.13?

zeripath added a commit to zeripath/gitea that referenced this pull request Feb 11, 2021
@zeripath
Allow org labels to be set with issue templates (go-gitea#14593)
d756903 
Backport go-gitea#14593

Fix go-gitea#13688

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Feb 11, 2021
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 11, 2021
6543 pushed a commit that referenced this pull request Feb 13, 2021
@zeripath @lunny
Allow org labels to be set with issue templates (#14593) (#14647)
a1b74c5 
Backport #14593

Fix #13688

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Issue template labels only get applied from default label set and org label set is ignored
6 participants
@zeripath @jolheiser @richmahn @lunny @6543 @GiteaBot