Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Unexport newRepoRedirect() & rm dedub del exec #14441

Closed
wants to merge 1 commit into from

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 23, 2021

while looking at #11649 I noticed things i fixed & refactored are copy-pasted things from ReopRedirect

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 23, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 23, 2021
@codecov-io
Copy link

Codecov Report

Merging #14441 (75ddcc3) into master (525d75c) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14441   +/-   ##
=======================================
  Coverage   41.76%   41.77%           
=======================================
  Files         748      748           
  Lines       80103    80101    -2     
=======================================
+ Hits        33455    33462    +7     
+ Misses      41125    41119    -6     
+ Partials     5523     5520    -3     
Impacted Files Coverage Δ
models/repo.go 52.41% <0.00%> (+0.08%) ⬆️
models/repo_redirect.go 70.83% <66.66%> (ø)
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 42.15% <0.00%> (-0.50%) ⬇️
modules/git/batch_reader_nogogit.go 46.26% <0.00%> (+1.49%) ⬆️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️
modules/git/repo_language_stats_nogogit.go 63.82% <0.00%> (+6.38%) ⬆️
modules/indexer/stats/db.go 68.00% <0.00%> (+12.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800c436...75ddcc3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 23, 2021
@zeripath
Copy link
Contributor

Just roll this into to #11649 - saves the CI and approval time.

@6543
Copy link
Member Author

6543 commented Jan 23, 2021

included in #11649

@6543 6543 closed this Jan 23, 2021
@6543 6543 deleted the refactor_RepoRedirect branch January 23, 2021 18:51
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants