Don't use sub-path twice for manifest

[uli-heller]

Fixes #14422

[techknowlogick]

Thanks for this PR!

It is failing on the CI due to needing to run make fmt on your local working copy and pushing the results of that.

[6543]

I'm not sure, adding a special var only for manifest is the right way to fix it

[uli-heller]

Feel free to change it! I do not know anything about go and my heart isn't connected with this pull request. All I know is that it fixes the issue for me. And I know it is not very nicely done. So: You surely don't offend me if you fix it differently

[6543]

First thanks for the pull, I think we can evolve your pull ;) together ...

[6543]

I would wait until #14293 got merged ...

[uli-heller]

Does someone know why the fix only works when using this ordering:

// OK - manifest contains correct urls
AbsoluteAssetURL = MakeAbsoluteAssetURL(AppURL, strings.TrimSuffix(sec.Key("STATIC_URL_PREFIX").MustString(""), "/"))
StaticURLPrefix = strings.TrimSuffix(sec.Key("STATIC_URL_PREFIX").MustString(AppSubURL), "/")

When I change the ordering, the manifest contains the wrong urls, those based on StaticURLPrefix:

// KO - manifest contains wrong urls based on StaticURLPrefix
StaticURLPrefix = strings.TrimSuffix(sec.Key("STATIC_URL_PREFIX").MustString(AppSubURL), "/")
AbsoluteAssetURL = MakeAbsoluteAssetURL(AppURL, strings.TrimSuffix(sec.Key("STATIC_URL_PREFIX").MustString(""), "/"))

[silverwind]

Hmm if this is really fixed by reordering statements, there must be another underlying issue that causes the variable to go wrong somewhere else. It must only be assigned once.

[uli-heller]

Sorry, maybe my explanation is misleading.

The issue is caused by this:

StaticURLPrefix = strings.TrimSuffix(sec.Key("STATIC_URL_PREFIX").MustString(AppSubURL), "/")

It makes "StaticURLPrefix" an URL that contains the sub-path twice, i.e. "https://mygitea.tld/gitea/gitea".
strings.TrimSuffix(sec.Key("STATIC_URL_PREFIX").MustString(""), "/") fixes this.

But only it is it called before StaticURLPrefix=strings.TrimSuffix(sec.Key("STATIC_URL_PREFIX").MustString("AppSubURL"), "/"). Currently, I don't understand why it has to be called first...

[6543]

could be #12999 an alternative for this pull?!?

[uli-heller]

@6543 : Shall I give it - #12999 - a try and report if it fixes the issue?

[6543]

@uli-heller would be nice

[uli-heller]

@6543 : Merging worked without an issue, building too. Unfortuntely, the issue is not fixed by #12999:

[6543]

thanks for your work & testing.

I'll close this since #14827 did catch the real issue behind it :)

[uli-heller]

@6543 : Thx a lot!