Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ghost comment mitigation #14349

Merged
merged 10 commits into from
Jan 17, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 15, 2021

Adds a config option USER_DELETE_WITH_COMMENTS_MAX_DAYS to the [service] section.

Source: https://codeberg.org/Codeberg/gitea/pulls/9
See https://codeberg.org/Codeberg/Discussion/issues/24 for the underlying issue.

Adds a config option USER_DELETE_WITH_COMMENTS_MAX_DAYS to the [service] section. See https://codeberg.org/Codeberg/Discussion/issues/24 for the underlying issue.
@6543 6543 added the type/enhancement An improvement of existing functionality label Jan 15, 2021
@6543 6543 marked this pull request as ready for review January 15, 2021 12:54
@6543 6543 added this to the 1.14.0 milestone Jan 15, 2021
@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@ca63a9d). Click here to learn what that means.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #14349   +/-   ##
=========================================
  Coverage          ?   41.84%           
=========================================
  Files             ?      744           
  Lines             ?    79737           
  Branches          ?        0           
=========================================
  Hits              ?    33363           
  Misses            ?    40865           
  Partials          ?     5509           
Impacted Files Coverage Δ
routers/user/setting/account.go 24.74% <0.00%> (ø)
models/user.go 53.63% <16.66%> (ø)
modules/setting/service.go 82.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca63a9d...11a9986. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2021
@6543 6543 merged commit 21da519 into go-gitea:master Jan 17, 2021
@6543 6543 deleted the ghost-comment-mitigation branch January 17, 2021 20:48
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 19, 2021
* master: (27 commits)
  Use path not filepath in routers/editor (go-gitea#14390)
  Display error if twofaSecret cannot be retrieved (go-gitea#14372)
  Check if label template exist first (go-gitea#14384)
  Allow passcode invalid error to appear (go-gitea#14371)
  exclude authored PRs from Review Requested filter (go-gitea#14368)
  Upgrade blevesearch dependency to v2.0.1 (go-gitea#14346)
  Implement ghost comment mitigation (go-gitea#14349)
  Add edit, delete and reaction support to code review comments on issue page (go-gitea#14339)
  Add review requested filter on pull request overview (go-gitea#13701)
  escape branch names in compare url (go-gitea#14364)
  label and milestone webhooks on issue/pull creation (go-gitea#14363)
  Fix middlewares sequences (go-gitea#14354)
  Sort issue search results by revelance (go-gitea#14353)
  KanBan: be able to set default board (go-gitea#14147)
  ...
6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 22, 2021
* Implement ghost comment mitigation

Adds a config option USER_DELETE_WITH_COMMENTS_MAX_DAYS to the [service] section. See https://codeberg.org/Codeberg/Discussion/issues/24 for the underlying issue.

* cleanup

* use setting module correctly

* add to docs

Co-authored-by: Moritz Marquardt <git@momar.de>
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Feb 26, 2021
* Implement ghost comment mitigation

Adds a config option USER_DELETE_WITH_COMMENTS_MAX_DAYS to the [service] section. See https://codeberg.org/Codeberg/Discussion/issues/24 for the underlying issue.

* cleanup

* use setting module correctly

* add to docs

Co-authored-by: Moritz Marquardt <git@momar.de>
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Mar 10, 2021
* Implement ghost comment mitigation

Adds a config option USER_DELETE_WITH_COMMENTS_MAX_DAYS to the [service] section. See https://codeberg.org/Codeberg/Discussion/issues/24 for the underlying issue.

* cleanup

* use setting module correctly

* add to docs

Co-authored-by: Moritz Marquardt <git@momar.de>
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants