Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror sync interval specified as duration string #1407

Merged
merged 14 commits into from
Apr 8, 2017
Merged

Mirror sync interval specified as duration string #1407

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3372c69
Sync interval specifed as duration string
cez81 Mar 29, 2017
29376da
Changed mirror interval text
cez81 Mar 29, 2017
91c3aaf
make fmt
cez81 Mar 29, 2017
5e7c691
Add MinInterval for mirror sync
cez81 Mar 29, 2017
f807596
Use duration internally
cez81 Mar 29, 2017
266fb0f
Changed min default to 10m
cez81 Mar 29, 2017
9b0df2d
make fmt
cez81 Mar 29, 2017
c1c0f8e
Incorrect default
cez81 Mar 29, 2017
c4c60b7
Removed defaults in MustDuration()
cez81 Mar 30, 2017
245c1a3
Add Mirror interval migration
cez81 Mar 30, 2017
2e85b22
Default values corrected
cez81 Mar 30, 2017
27c1ec9
Use transaction during migration
cez81 Apr 6, 2017
6ea0e06
Change http 500 to page with error message
cez81 Apr 6, 2017
ee651c1
Cleanup session.commit()
cez81 Apr 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/setting/setting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,8 +903,8 @@ please consider changing to GITEA_CUSTOM`)
}

sec = Cfg.Section("mirror")
Mirror.MinInterval = sec.Key("MIN_INTERVAL").MustDuration(time.Second * 55)
Mirror.DefaultInterval = sec.Key("DEFAULT_INTERVAL").MustDuration(time.Hour * 55)
Mirror.MinInterval = sec.Key("MIN_INTERVAL").MustDuration()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm somethings not right with this. Doesn't read default from built in app.ini

Mirror.DefaultInterval = sec.Key("DEFAULT_INTERVAL").MustDuration()
if Mirror.MinInterval.Minutes() < 1 {
log.Warn("Invalid Mirror.MinInterval")
Mirror.MinInterval = time.Second * 60
Expand Down