Add emoji in label to project boards #13978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to upstream
Added rendering of emoji to project label
Codecov Report
@@ Coverage Diff @@
## master #13978 +/- ##
=======================================
Coverage 42.21% 42.22%
=======================================
Files 710 710
Lines 77233 77233
=======================================
+ Hits 32603 32609 +6
- Misses 39252 39254 +2
+ Partials 5378 5370 -8
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
zeripath
reviewed
Dec 14, 2020
zeripath
approved these changes
Dec 14, 2020
GiteaBot
added
lgtm/need 1
|
@zeripath should we add this to 1.13.1? |
|
Yup - I was just checking what the code base looked like on 1.13 - it appears that this can be backported as it stands. |
zeripath
added
backport/v1.13
topic/ui
6543
approved these changes
Dec 14, 2020
GiteaBot
added
lgtm/done
|
@rakshith-ravi pleace send backport 👍 |
|
@6543 how do I do that? |
|
checkout to the release branch & cherry pick 729f0f5 should I do it for you? |
|
Nah I'll do it. I wanna learn to backport :D |
|
@rakshith-ravi some hints: git fetch --all
git checkout -f upstream/release/v1.13 -b backport_13978
git cherry-pick 729f0f5f7b
git push -u fork backport_13978-> create pull fork is remote to your fork |
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Dec 16, 2020
* Update view.tmpl Added rendering of emoji to project label * Add RenderEmojiPlain to the title and remove has-emoji Co-authored-by: zeripath <art27@cantab.net>
|
@rakshith-ravi did a backport for you -> #14021 |
techknowlogick
pushed a commit
that referenced
this pull request
Dec 16, 2020
* Update view.tmpl Added rendering of emoji to project label * Add RenderEmojiPlain to the title and remove has-emoji Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Rakshith Ravi <rakshith.ravi@gmx.com> Co-authored-by: zeripath <art27@cantab.net>
|
Hey. Thanks. My laptop just broke and I wouldn't have been able to do it till the weekend. Sorry about the delay |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Fixes #13880
CC @modmew8