Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for webhook and feishu caused by API changed. #13937

Merged
merged 4 commits into from
Dec 11, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 11, 2020

Just found the type on webhook table has some spaces so that webhook cannot be fired correctly.

This also fix feishu webhook since the API changed. fix #13858, #13907

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 11, 2020
@lunny lunny changed the title Fix bug for webhook Fix bug for webhook and feishu caused by API changed. Dec 11, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #13937 (589279b) into master (c11cf4b) will decrease coverage by 0.00%.
The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13937      +/-   ##
==========================================
- Coverage   42.21%   42.20%   -0.01%     
==========================================
  Files         710      710              
  Lines       77232    77207      -25     
==========================================
- Hits        32604    32589      -15     
+ Misses      39264    39243      -21     
- Partials     5364     5375      +11     
Impacted Files Coverage Δ
services/webhook/feishu.go 0.00% <0.00%> (ø)
models/webhook.go 69.06% <100.00%> (+0.09%) ⬆️
services/webhook/webhook.go 53.46% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
services/pull/check.go 48.90% <0.00%> (-2.92%) ⬇️
modules/notification/ui/ui.go 93.05% <0.00%> (-2.78%) ⬇️
models/notification.go 66.25% <0.00%> (-0.99%) ⬇️
models/error.go 38.49% <0.00%> (-0.82%) ⬇️
services/pull/pull.go 40.68% <0.00%> (-0.50%) ⬇️
modules/notification/mail/mail.go 39.08% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11cf4b...589279b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2020
6543 pushed a commit that referenced this pull request Dec 11, 2020
@6543 6543 added the backport/done All backports for this PR have been created label Dec 11, 2020
@zeripath
Copy link
Contributor

make lgtm work

@lunny
Copy link
Member Author

lunny commented Dec 11, 2020

According #13907 (comment), it seems it still not resolve the problem. Wait until I confirm that.

@6543 6543 merged commit ea914d0 into go-gitea:master Dec 11, 2020
@6543
Copy link
Member

6543 commented Dec 11, 2020

According #13907 (comment), it seems it still not resolve the problem. Wait until I confirm that.

@lunny sorry had red it to late

@lunny lunny deleted the lunny/fix_webhook branch December 12, 2020 01:51
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use FeiShu Webhook
6 participants