Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action avatar loading #13909

Merged
merged 4 commits into from
Dec 9, 2020
Merged

Fix action avatar loading #13909

merged 4 commits into from
Dec 9, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 8, 2020

Fixes: #13883

Wasn't able to reproduce the error but I'm pretty confident this fixes it.

@6543
Copy link
Member

6543 commented Dec 9, 2020

uff in the end it had become 5 herpers only for avatars ...

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 9, 2020
@silverwind
Copy link
Member Author

Yeah, not too happy about that either, but the code pretty much requires it currently, thought I guess it could be refactored later to less helpers in some cases.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 9, 2020
@lafriks lafriks merged commit 97ab820 into go-gitea:master Dec 9, 2020
@silverwind silverwind deleted the actava branch December 9, 2020 08:31
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On dashboard feed, avatar func create nil exeption
4 participants