Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move notification APIFormat #13783

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 2, 2020

as title

@6543 6543 added this to the 1.14.0 milestone Dec 2, 2020
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 2, 2020
@codecov-io
Copy link

Codecov Report

Merging #13783 (724aaab) into master (253add8) will decrease coverage by 0.00%.
The diff coverage is 63.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13783      +/-   ##
==========================================
- Coverage   42.23%   42.22%   -0.01%     
==========================================
  Files         699      700       +1     
  Lines       76959    76959              
==========================================
- Hits        32500    32496       -4     
- Misses      39094    39097       +3     
- Partials     5365     5366       +1     
Impacted Files Coverage Δ
models/notification.go 66.25% <ø> (+0.49%) ⬆️
modules/convert/notification.go 60.52% <60.52%> (ø)
routers/api/v1/notify/repo.go 72.97% <100.00%> (ø)
routers/api/v1/notify/threads.go 56.25% <100.00%> (ø)
routers/api/v1/notify/user.go 25.00% <100.00%> (ø)
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 253add8...724aaab. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2020
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2020
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not certain about whether convert is the nicest design - I guess it's one way of coming up with an exportable set of models even if we don't use them internally.

However, this PR makes notification consistent with the rest of the library, therefore LGTM.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2020
@zeripath zeripath merged commit 4f5ff1e into go-gitea:master Dec 2, 2020
@6543 6543 deleted the refactorToAPIFormat branch December 2, 2020 11:42
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants