Reply button is not removed when deleting a code review comment

[jpraet]

Fixes #13764

This adds a conversation-wrapper div around a code review comment thread. When the last comment in the conversation gets deleted, the conversation-wrapper now also gets deleted, removing the reply / (un)resolve buttons and resolved conversation wrapper.

I also extracted the conversation, which was duplicated in box.tmpl (left+right) and section_unified.tmpl, into a separate template.

[codecov-io]

Codecov Report

Merging #13774 (c947e43) into master (4353cf9) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13774      +/-   ##
==========================================
- Coverage   42.24%   42.17%   -0.08%     
==========================================
  Files         708      708              
  Lines       77145    77145              
==========================================
- Hits        32593    32537      -56     
- Misses      39182    39262      +80     
+ Partials     5370     5346      -24     

Impacted Files	Coverage Δ
modules/notification/ui/ui.go	84.72% <0.00%> (-8.34%)	⬇️
models/issue_comment.go	45.46% <0.00%> (-6.80%)	⬇️
modules/notification/mail/mail.go	33.33% <0.00%> (-5.75%)	⬇️
modules/git/commit.go	49.67% <0.00%> (-3.95%)	⬇️
modules/notification/base/null.go	74.28% <0.00%> (-2.86%)	⬇️
modules/notification/notification.go	83.92% <0.00%> (-2.68%)	⬇️
modules/queue/unique_queue_disk_channel.go	53.84% <0.00%> (-1.54%)	⬇️
services/mailer/mail.go	60.21% <0.00%> (-1.08%)	⬇️
services/pull/pull.go	40.68% <0.00%> (-0.50%)	⬇️
models/repo.go	51.72% <0.00%> (+0.16%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4353cf9...c947e43. Read the comment docs.

[6543]

@jpraet by the way: if you allow maintainers to edit pulls - we could update pull's too :)

Pleace update branch

[lafriks]

please merge latest changes

[jpraet]

@jpraet by the way: if you allow maintainers to edit pulls - we could update pull's too :)

For some reason the "Allow edits from maintainers" checkbox is not showing up for me.

[lafriks]

yeah, I think it is available only when creating PR :(

[silverwind]

Very nice work, always great to see template deduplications which we are very guilty of 😉

[6543]

we should backport the fix - but I'm not sure if we should also backport template dedub?

[silverwind]

This also has a dependency on the new mergeinto helper which I think is not in 1.13.

[6543]

@jpraet can you create a backport to 1.13 without the dedublication refactor ?

[jpraet]

@6543 ok