Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix avatar offset on PR/issue timeline view #13753

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Fix avatar offset on PR/issue timeline view #13753

merged 2 commits into from
Nov 30, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Nov 30, 2020

Before:
firefox_2020-11-30_01-41-39

After:
firefox_2020-11-30_01-50-37

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Nov 30, 2020
@codecov-io
Copy link

Codecov Report

Merging #13753 (24117e8) into master (63aeb0a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13753   +/-   ##
=======================================
  Coverage   42.23%   42.23%           
=======================================
  Files         699      699           
  Lines       76957    76957           
=======================================
+ Hits        32503    32505    +2     
  Misses      39090    39090           
+ Partials     5364     5362    -2
Impacted Files Coverage Δ
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
modules/avatar/avatar.go 54.76% <0.00%> (+4.76%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63aeb0a...24117e8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 30, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2020
@CirnoT @silverwind
Apply suggestions from code review
79565fc 
Co-authored-by: silverwind <me@silverwind.io>
@lafriks lafriks merged commit d7ab726 into go-gitea:master Nov 30, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 30, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 30, 2020
@CirnoT CirnoT deleted the avatar-offset branch November 30, 2020 17:40
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@CirnoT @codecov-io @silverwind @lafriks @lunny @GiteaBot