-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chronological commit order in default squash message #13696
Use chronological commit order in default squash message #13696
Conversation
PR looks fine. As for newline squashing, I guess we could prefix the first line of a commit message with a
|
Please update branch |
Could you clarify? Should I rebase on latest go-gitea:master? |
There should be an update branch button at the bottom of the comments on this PR that will do it for you |
Fixes #13661
Note that the ticket also mentioned potentially removing the empty lines between commit messages. I haven't changed that for now because I'm not too sure about it. If you are squashing multiple commits, all with detailed multi-line commit messages, maybe the newlines are useful. Although one could also argue that the commit message details should maybe not be included in the squash message (only use the commit message titles)?