Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up PostgreSQL Tests #1361

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Clean-up PostgreSQL Tests #1361

merged 1 commit into from
Mar 22, 2017

Conversation

bkcsoft
Copy link
Member

@bkcsoft bkcsoft commented Mar 22, 2017

This just seems cleaner in my opinion

@bkcsoft bkcsoft added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing labels Mar 22, 2017
@lunny lunny added this to the 1.2.0 milestone Mar 22, 2017
@strk
Copy link
Member

strk commented Mar 22, 2017

To be honest I find the short version cleaner (sorry)

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2017
@lunny
Copy link
Member

lunny commented Mar 22, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2017
@lunny lunny merged commit d349f05 into master Mar 22, 2017
@bkcsoft bkcsoft deleted the bkcsoft/cleanup-postgres-test branch June 15, 2017 02:42
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bkcsoft @strk @lunny @appleboy @tboerger