Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fomatic Build #13593

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fix Fomatic Build #13593

merged 1 commit into from
Nov 16, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 16, 2020

as title

@6543 6543 added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 16, 2020
silverwind
silverwind reviewed Nov 16, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 16, 2020
@silverwind
Copy link
Member

silverwind commented Nov 16, 2020 •
edited
Loading

We can port this to newer versions as well, never hurts to override those destinations.

silverwind added a commit to silverwind/gitea that referenced this pull request Nov 16, 2020
@silverwind
Fix Fomatic Build
f0bb405 
Port of go-gitea#13593 to 1.14
@silverwind silverwind mentioned this pull request Nov 16, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this pull request Nov 16, 2020
@silverwind
Fix Fomatic Build
a204e87 
Port of go-gitea#13593 to 1.13
@silverwind silverwind mentioned this pull request Nov 16, 2020
Merged
@silverwind
Copy link
Member

Ports in #13595 and #13596.

@6543 6543 added this to the 1.12.7 milestone Nov 16, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2020
techknowlogick pushed a commit that referenced this pull request Nov 16, 2020
@silverwind
Fix Fomatic Build (#13595)
949e3f5 
Port of #13593 to 1.14
techknowlogick pushed a commit that referenced this pull request Nov 16, 2020
@silverwind
Fix Fomatic Build (#13596)
c6ab79e 
Port of #13593 to 1.13
@techknowlogick techknowlogick merged commit f845fa0 into go-gitea:release/v1.12 Nov 16, 2020
@6543 6543 deleted the fix-fomatic-build branch November 16, 2020 23:03
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.12.7
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @silverwind @mrsdizzie @techknowlogick @GiteaBot