Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken .comment > .content caused by #13457 #13482

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Nov 9, 2020

I have no idea how it happened but somehow I completely missed the fact that .comment > .content does not refer to actual comments only but also to all other boxes on comment timeline.

Before:
firefox_2020-11-09_21-03-14

After:
chrome_2020-11-09_21-23-04

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 9, 2020
@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #13482 (bf338d4) into master (77e5081) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13482      +/-   ##
==========================================
+ Coverage   42.05%   42.19%   +0.13%     
==========================================
  Files         694      694              
  Lines       76334    76334              
==========================================
+ Hits        32105    32210     +105     
+ Misses      38971    38855     -116     
- Partials     5258     5269      +11     
Impacted Files Coverage Δ
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
models/error.go 36.06% <0.00%> (+0.83%) ⬆️
models/notification.go 66.66% <0.00%> (+0.90%) ⬆️
services/pull/pull.go 41.27% <0.00%> (+0.98%) ⬆️
services/pull/check.go 51.09% <0.00%> (+2.18%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/notification/notification.go 86.60% <0.00%> (+2.67%) ⬆️
modules/notification/base/null.go 77.14% <0.00%> (+2.85%) ⬆️
modules/git/commit.go 53.61% <0.00%> (+3.94%) ⬆️
modules/notification/mail/mail.go 39.08% <0.00%> (+5.74%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e5081...bf338d4. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 9, 2020
@6543 6543 added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 9, 2020
@techknowlogick techknowlogick merged commit 40c4466 into go-gitea:master Nov 10, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 10, 2020
@CirnoT CirnoT deleted the fix-13457 branch November 10, 2020 14:57
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants