Remove href on first/last link when on first/last page #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Loupforest <arthur.loupforest@outlook.fr>
appleboy
approved these changes
Mar 21, 2017
|
LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
|
Why no merge @lunny ? |
|
@tboerger Can you help to merge this PR? |
|
@strk Only three people have permission to merge PR. https://github.com/orgs/go-gitea/teams/owners |
aloupfor
deleted the
remove-href-on-first-last-link-when-on-first-last-page
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are on the first page of explore, the "First" link in pagination appears as disabled but it still has a
hrefand so is clickable. Same thing for the "Last" link on the last page.This PR aims to only have the
hrefwhen the links are "enabled".