Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override fomantic monospace fonts and set size #13435

Merged
merged 3 commits into from
Nov 6, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 5, 2020

We did not override those yet so default monospace was applied. Also added a tweak to slightly reduce font size because monospace fonts usually render slightly larger than proportional ones.

Before:
Screen Shot 2020-11-05 at 20 00 34

After:
Screen Shot 2020-11-05 at 20 04 49

Original fomantic style was:

code, kbd, samp {
    font-family: monospace,monospace;
    font-size: 1em;
}

We did not override those yet so default `monospace` was applied. Also
added a tweak to slightly reduce font size because monospace fonts
usually render slightly larger than proportional ones.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 5, 2020
@jolheiser jolheiser added the topic/ui Change the appearance of the Gitea UI label Nov 5, 2020
@jolheiser jolheiser added this to the 1.14.0 milestone Nov 5, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit eebaa81 into go-gitea:master Nov 6, 2020
@silverwind silverwind deleted the code-font branch November 6, 2020 17:21
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants