Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency in layout #1316

Merged
merged 1 commit into from
Mar 18, 2017
Merged

Fix inconsistency in layout #1316

merged 1 commit into from
Mar 18, 2017

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented Mar 17, 2017

@strk This fixes the overlap you introduced in #618

@pgaskin pgaskin mentioned this pull request Mar 17, 2017
Closed
@lunny lunny added this to the 1.2.0 milestone Mar 18, 2017
@lunny lunny added the type/bug label Mar 18, 2017
@strk
Copy link
Member

strk commented Mar 18, 2017

is this change in staging for review?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2017
@strk
Copy link
Member

strk commented Mar 18, 2017

Trusted LGTM anyway

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 18, 2017
@lunny
Copy link
Member

lunny commented Mar 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2017
@lunny lunny merged commit b57b0c6 into go-gitea:master Mar 18, 2017
@strk
Copy link
Member

strk commented Mar 19, 2017

I still see an inconsistency in layout here: https://try.gitea.io/user/settings/openid

@strk
Copy link
Member

strk commented Mar 19, 2017

Version on try.gitea.io is 1.1.0+47-g1c3bd436 so it looks like it wasn't synced with latest merge from 21 hours ago ! @tboerger

@pgaskin pgaskin deleted the patch-7 branch May 24, 2017 01:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pgaskin @strk @lunny @tboerger @geek1011