Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue & Pull Request comment headers on mobile #13039

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Oct 5, 2020

This PR fixes the Issue and PR comment headers on mobile. The changes I made also work on desktop which is why I didn't use media queries. This has the nice side effect to make the header look good in edge cases where user's have really long names which wouldn't fit the header even on desktop.

We could also discuss hiding the avatar completely and let the comments take the full width on mobile (like github does) but that would be a separate change.

Before:

Screen Shot 2020-10-05 at 21 55 37

After:

Screen Shot 2020-10-05 at 21 58 29

Signed-off-by: kolaente <k@knt.li>
@codecov-commenter
Copy link

Codecov Report

Merging #13039 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13039      +/-   ##
==========================================
- Coverage   42.62%   42.60%   -0.02%     
==========================================
  Files         672      672              
  Lines       73785    73785              
==========================================
- Hits        31448    31439       -9     
- Misses      37247    37253       +6     
- Partials     5090     5093       +3     
Impacted Files Coverage Δ
modules/indexer/stats/db.go 60.86% <0.00%> (-8.70%) ⬇️
modules/log/event.go 56.60% <0.00%> (-0.95%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1c51c...66cc58e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 5, 2020
@6543 6543 added the type/bug label Oct 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 5, 2020
@techknowlogick techknowlogick merged commit 78aded1 into go-gitea:master Oct 5, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Oct 5, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants