-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show PR settings on empty repos #12808
Merged
zeripath
merged 4 commits into
go-gitea:master
from
zeripath:fix-12788-show-pr-settings-on-empty-repos
Sep 11, 2020
Merged
Show PR settings on empty repos #12808
zeripath
merged 4 commits into
go-gitea:master
from
zeripath:fix-12788-show-pr-settings-on-empty-repos
Sep 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#12788 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Sep 10, 2020
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Sep 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #12808 +/- ##
==========================================
+ Coverage 43.16% 43.19% +0.02%
==========================================
Files 651 651
Lines 72145 72145
==========================================
+ Hits 31142 31161 +19
+ Misses 35949 35935 -14
+ Partials 5054 5049 -5
Continue to review full report at Codecov.
|
mrsdizzie
approved these changes
Sep 11, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Sep 11, 2020
lunny
reviewed
Sep 11, 2020
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the settings page would not show the PR section if the repository was empty.
Fix #12788
Signed-off-by: Andrew Thornton art27@cantab.net