Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when creating gitlabdownloader failed #12790

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 10, 2020

related with #12779

@codecov-commenter
Copy link

Codecov Report

Merging #12790 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12790      +/-   ##
==========================================
+ Coverage   43.23%   43.24%   +0.01%     
==========================================
  Files         650      650              
  Lines       72048    72041       -7     
==========================================
+ Hits        31150    31155       +5     
+ Misses      35852    35842      -10     
+ Partials     5046     5044       -2     
Impacted Files Coverage Δ
modules/migrations/gitlab.go 1.06% <0.00%> (+0.01%) ⬆️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
models/gpg_key.go 54.81% <0.00%> (-0.59%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
models/error.go 35.66% <0.00%> (+0.85%) ⬆️
models/notification.go 67.04% <0.00%> (+0.91%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b333aa7...ff8a843. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2020
@6543
Copy link
Member

6543 commented Sep 10, 2020

thanks

@6543 6543 mentioned this pull request Sep 10, 2020
12 tasks
@lafriks lafriks merged commit 0db9043 into go-gitea:master Sep 10, 2020
@lafriks lafriks added this to the 1.13.0 milestone Sep 10, 2020
@lunny lunny deleted the lunny/fix_gitlab branch September 10, 2020 08:28
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants