-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Migration: Change ServiceType String #12672
[API] Migration: Change ServiceType String #12672
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12672 +/- ##
==========================================
- Coverage 43.22% 43.19% -0.04%
==========================================
Files 651 651
Lines 72118 72134 +16
==========================================
- Hits 31175 31156 -19
- Misses 35898 35931 +33
- Partials 5045 5047 +2
Continue to review full report at Codecov.
|
1cd9dd5
to
6f46bc2
Compare
@lunny I think I should fix this upstream ... at the moment eaven a -> Resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this PR, when I toggle mirror checkbox it should disable option to migrate issues,PRs, etc..
@jolheiser I'll test it again - hope it still works... |
a935a4c
to
0427ebf
Compare
@jolheiser no it broke "pre selection" to Git Line 272 in 3270e7a
☝️ yes it is no struct but this type has a type-function called Title() |
I see, my bad. But now I have another concern. This PR doesn't actually change the enums to strings, it just provides a way to convert strings into a I'm a little worried that this adds unneeded complexity, is it not possible to change the enum to a string, or perhaps just a wrapper for the API? |
yes it is doable - will resullt in dublicating the struct ... |
0427ebf
to
b7ea054
Compare
@jolheiser Done |
I included the refactor because I think it is realy needed in this pull ... Refactor:
|
@techknowlogick If this is all you can find then I'm totaly fine with it 🙃 |
Please resolve the conflicts. |
@lunny done |
@zeripath added doc what purpose each struct has @techknowlogick can you either dismiss review or have a look at it? |
thanks @ techknowlogick |
@zeripath thanks :) |
close #12630