Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate logic in initListSubmits #12660

Merged
merged 8 commits into from
Sep 2, 2020
Merged

Remove duplicate logic in initListSubmits #12660

merged 8 commits into from
Sep 2, 2020

Conversation

a1012112796
Copy link
Member

Using the same logic to handle Choosing reviewers and assignees as choosing label. It's the first step of #10926.

@a1012112796
Remove duplicate logic in initListSubmits
f114356 
Using the same logic to handle Choosing reviewers and assignees as
choosing label. It's the first step of go-gitea#10926.

Signed-off-by: a1012112796 <1012112796@qq.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2020 •
edited
Loading

Codecov Report

Merging #12660 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12660      +/-   ##
==========================================
- Coverage   43.32%   43.31%   -0.01%     
==========================================
  Files         646      646              
  Lines       71592    71593       +1     
==========================================
- Hits        31015    31009       -6     
- Misses      35565    35570       +5     
- Partials     5012     5014       +2
Impacted Files Coverage Δ
routers/repo/issue.go 37.51% <0.00%> (-0.03%) ⬇️
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
models/notification.go 66.13% <0.00%> (-0.92%) ⬇️
models/error.go 34.81% <0.00%> (-0.86%) ⬇️
modules/git/repo.go 49.74% <0.00%> (+0.50%) ⬆️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3270e7a...dddf3f9. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2020
@6543
Copy link
Member

6543 commented Aug 31, 2020

could it potentialf fix #12643 ?

@a1012112796
Copy link
Member Author

a1012112796 commented Aug 31, 2020 •
edited
Loading

could it potentialf fix #12643 ?

Not fixed. And I think this logic is necessary, Because if user choose one item then quickly dischoose it, nothing should be done, which is same with GH. Maybe we should do something to check close page...

@a1012112796

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 31, 2020
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 31, 2020
@lafriks lafriks added this to the 1.13.0 milestone Aug 31, 2020
@6543
Copy link
Member

6543 commented Sep 1, 2020

asign asignees and re-review-request do not work anymore

@a1012112796
Copy link
Member Author

asign asignees and re-review-request do not work anymore

Hello, I‘m sorry, but I haven't faced the bug which you reported. So I don't know why either. Can you tell me which type of browser you are using? or give me some screenshoots. Thanks.
@CirnoT @silverwind @Sorien , Please have a look. Thanks.

@a1012112796
Copy link
Member Author

@6543 Maaybe because of ban-change undefined, Please test again. Thanks.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 2, 2020
@6543
Copy link
Member

6543 commented Sep 2, 2020

now it works

@a1012112796
Copy link
Member Author

Suggest backport :)

@6543
Copy link
Member

6543 commented Sep 2, 2020

@a1012112796 since its a refactor and no bugfix, why should we backport?

@a1012112796
Copy link
Member Author

@a1012112796 since its a refactor and no bugfix, why should we backport?
the small nit about ban-change :)

@6543
Copy link
Member

6543 commented Sep 2, 2020

well then I only would pick out the bugfix for backport ...

@techknowlogick techknowlogick merged commit 3981f1b into go-gitea:master Sep 2, 2020
@a1012112796 a1012112796 deleted the fix_sidebar branch November 1, 2020 06:35
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@a1012112796 @codecov-commenter @6543 @lafriks @techknowlogick @GiteaBot