Add postgres schema to the search_path on database connection #12634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
added
the
type/feature
Rather than rely on the user running the gitea server and db setting the schema search_path correctly - if gitea is run with a schema we should simply set the search_path to have that schema first in the path. Fix go-gitea#12505 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
fix-12505-set-schema-search-path
branch
from
e1e2cb9
to
1e75afc
Compare
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #12634 +/- ##
==========================================
- Coverage 43.19% 43.15% -0.05%
==========================================
Files 651 651
Lines 72138 72145 +7
==========================================
- Hits 31163 31136 -27
- Misses 35928 35955 +27
- Partials 5047 5054 +7
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
Sep 7, 2020
silverwind
approved these changes
Sep 8, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Sep 10, 2020
GiteaBot
added
lgtm/done
|
🚀 |
zeripath
added
type/enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than rely on the user running the gitea server and db setting the
schema search_path correctly - if Gitea is run with a schema we should
simply set the search_path to have that schema first in the path.
Fix #12505
Signed-off-by: Andrew Thornton art27@cantab.net