Set context for running CreateArchive to that of the request #12555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the context for CreateArchive to that of the request to ensure that archives are only built for as long as a request is requesting them Fix go-gitea#11551 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #12555 +/- ##
==========================================
+ Coverage 43.43% 43.45% +0.01%
==========================================
Files 645 645
Lines 71306 71306
==========================================
+ Hits 30972 30984 +12
+ Misses 35324 35313 -11
+ Partials 5010 5009 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
So the timeout is the one http client default value? |
|
The timeout becomes the request context, that is if the user is still requesting the archive it still gets created. It just solves the initial issue. We need something more like the migration creation task based approach in general, @kevans91 was doing some work in that direction but the PR # escapes me right now. |
|
PR #11296 |
zeripath
changed the title
techknowlogick
approved these changes
Aug 28, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Aug 28, 2020
GiteaBot
added
lgtm/done
zeripath
deleted the
fix-11551-set-default-command-timeout-for-git-archive
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the context for CreateArchive to that of the request to ensure that archives
are only built for as long as a request is requesting them
Fix #11551
Signed-off-by: Andrew Thornton art27@cantab.net