Don't use -webkit-font-smoothing #12029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't change font smoothing via CSS. Linked issue has more details, but this seems fowned upon in general and a was also removed from standards track. Hopefully this will be a part of reverting to a native font stack for Gitea. Fixes go-gitea#11931
CirnoT
approved these changes
Jun 23, 2020
GiteaBot
added
the
lgtm/need 1
silverwind
approved these changes
Jun 23, 2020
GiteaBot
added
lgtm/done
|
Fomantic sets this on it's icon font, maybe we want to override it to the browser default but I'm not sure of it's impact. Maybe @CirnoT can try if this makes any difference in the icon rendering. i.icon {
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
} |
|
The less we touch Fomantic overrides the better imo |
|
ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Don't change font smoothing via CSS. Linked issue has more details, but this seems fowned upon in general and a was also removed from standards track. Hopefully this will be a part of reverting to a native font stack for Gitea. Fixes go-gitea#11931 Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't change font smoothing via CSS. Linked issue has more details, but this seems fowned upon in general and a was also removed from standards track (and we don't do it on Firefox already). Hopefully this will be a part of reverting to a native font stack for Gitea.
Fixes #11931