Add type filter to System Notices view #11909
Conversation
After go-gitea#10745 was merged, the number of System Notices increased obviously. Add the type filter is useful to help users to quickly check out the useful message they want. Signed-off-by: a1012112796 <1012112796@qq.com>
techknowlogick
added
type/enhancement
|
can you add a smal screenshot? |
GiteaBot
added
the
lgtm/need 2
ok |
|
How about move the filter to right? |
Co-authored-by: Lauris BH <lauris@nix.lv>
| @@ -20,8 +20,10 @@ type NoticeType int | |||
| const ( | |||
| //NoticeRepository type | |||
| NoticeRepository NoticeType = iota + 1 | |||
| // NoticeTask type | |||
| NoticeTask | |||
There was a problem hiding this comment.
I would like we have a new column named status but not put all in type
There was a problem hiding this comment.
Hmm, I'm not sure whether it's a good idea because it will result in big changs and it's not usefull for NoticeRepository now. 🤔
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
|
Bump |
lunny
added
the
issue/confirmed
|
updates? |
Hmm, I think this pull requst is not so necessary now. because we can disable |
|
I think we should be able to filter, more specific: why not add a search-box to filter by keywords? created #14228 |
After #10745 was merged, the number of System Notices increased obviously.
Add the type filter is useful to help users to quickly check out the useful message they want.
view:
