Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api.Context.NotFound(...) should tolerate nil (#11288) #11306

Merged
merged 1 commit into from
May 5, 2020
Merged

api.Context.NotFound(...) should tolerate nil (#11288) #11306

merged 1 commit into from
May 5, 2020

Commits on May 5, 2020

  1. api.Context.NotFound(...) should tolerate nil (go-gitea#11288) 

    There is an unfortunate signature change with the api.Context
NotFound function; whereas the normal modules/context/Context
NotFound function requires an error or nil, the api.Context
variant will panic with an NPE if a nil is provided.

This PR will allow api.Context.NotFound to tolerate a being
passed a nil.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
    @zeripath @lafriks
    zeripath and lafriks committed May 5, 2020
    Configuration menu
    Copy the full SHA
    868222d View commit details
    Browse the repository at this point in the history