Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pull request selection even when unrelated branches #11239

Merged

Conversation

zeripath
Copy link
Contributor

Fix #10525

Signed-off-by: Andrew Thornton art27@cantab.net

Fix go-gitea#10525

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.12.0 milestone Apr 28, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #11239 into master will increase coverage by 0.55%.
The diff coverage is 39.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11239      +/-   ##
==========================================
+ Coverage   43.25%   43.81%   +0.55%     
==========================================
  Files         601      607       +6     
  Lines       85544    86876    +1332     
==========================================
+ Hits        37004    38061    +1057     
- Misses      43966    44118     +152     
- Partials     4574     4697     +123     
Impacted Files Coverage Δ
cmd/dump.go 0.00% <0.00%> (ø)
models/error.go 32.45% <0.00%> (-0.18%) ⬇️
models/user.go 49.66% <ø> (ø)
modules/indexer/code/indexer.go 38.02% <0.00%> (ø)
modules/indexer/issues/indexer.go 55.94% <0.00%> (-0.25%) ⬇️
modules/markup/markdown/ast.go 0.00% <0.00%> (ø)
modules/markup/markdown/renderconfig.go 0.00% <0.00%> (ø)
modules/markup/markdown/toc.go 0.00% <0.00%> (ø)
modules/migrations/base/pullrequest.go 0.00% <ø> (ø)
modules/migrations/gitlab.go 1.67% <0.00%> (-0.09%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452b69b...8d46fd3. Read the comment docs.

@lunny lunny merged commit 28f8308 into go-gitea:master May 2, 2020
@lunny
Copy link
Member

lunny commented May 2, 2020

Please send backport

guillep2k added a commit to guillep2k/gitea that referenced this pull request May 3, 2020
)

Fix go-gitea#10525

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@guillep2k guillep2k added the backport/done All backports for this PR have been created label May 3, 2020
zeripath pushed a commit that referenced this pull request May 4, 2020
…1283)

Fix #10525

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
)

Fix go-gitea#10525

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@zeripath zeripath deleted the fix-10525-show-selection-box-unrelated branch September 13, 2020 12:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull request selection with unrelated branches
6 participants