-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repository release count when converting for API #10968
Merged
zeripath
merged 7 commits into
go-gitea:master
from
6543-forks:fix-api-RepoInfo-ReleaseCounter_10946
Apr 6, 2020
Merged
Fix repository release count when converting for API #10968
zeripath
merged 7 commits into
go-gitea:master
from
6543-forks:fix-api-RepoInfo-ReleaseCounter_10946
Apr 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
commented
Apr 5, 2020
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #10968 +/- ##
==========================================
- Coverage 43.62% 43.55% -0.08%
==========================================
Files 597 597
Lines 83923 83923
==========================================
- Hits 36614 36554 -60
- Misses 42797 42862 +65
+ Partials 4512 4507 -5
Continue to review full report at Codecov.
|
6543
force-pushed
the
fix-api-RepoInfo-ReleaseCounter_10946
branch
from
April 5, 2020 23:25
3eeb7bb
to
eb2f73b
Compare
@lunny I removed the NumReleases from the Repo struct |
zeripath
approved these changes
Apr 6, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Apr 6, 2020
mrsdizzie
approved these changes
Apr 6, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 6, 2020
make lg-tm work |
zeripath
changed the title
[BugFix] [API] repo info release counter
Fix release counter on API repository info
Apr 6, 2020
zeripath
changed the title
Fix release counter on API repository info
Fix repository release count when converting for API
Apr 6, 2020
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Apr 6, 2020
techknowlogick
added
backport/done
All backports for this PR have been created
backport/v1.11
labels
Apr 6, 2020
techknowlogick
pushed a commit
that referenced
this pull request
Apr 6, 2020
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Use the same mechanism as the webpage for calculating the release count Fix go-gitea#10946
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/api
This PR adds API routes or modifies them
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10946