-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix topics dropdown #10167
Fix topics dropdown #10167
Conversation
Signed-off-by: jolheiser <john.olheiser@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems correct according to https://semantic-ui.com/modules/dropdown.html#match-search-query-on-server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably fomantic is doing the encodeUriComponent itself?
Codecov Report
@@ Coverage Diff @@
## master #10167 +/- ##
==========================================
+ Coverage 43.4% 43.41% +0.01%
==========================================
Files 576 576
Lines 79640 79640
==========================================
+ Hits 34566 34575 +9
+ Misses 40798 40789 -9
Partials 4276 4276
Continue to review full report at Codecov.
|
I think fetch/XHR do that automatically in any case. |
Awesome, thank you for this fast fix! 🙏 |
Fixes #10160
Related to fomantic switch, so needs a backport as well.
Note that
{variable}
is semantic syntax, not JS${variable}