Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Diff Patch support #10007

Closed
wants to merge 2 commits into from
Closed

Conversation

zeripath
Copy link
Contributor

This code adds a simple endpoint to add diff patch application to Gitea

  • Initial implementation of ApplyDiffPatch - can be tested at /owner/repo/_diffpatch/branch or on API
  • Wire in to UI
  • Better error support

@zeripath zeripath added type/feature Completely new functionality. Can only be merged if feature freeze is not active. pr/wip This PR is not ready for review labels Jan 26, 2020
@6543
Copy link
Member

6543 commented Jan 26, 2020

step towards #9388

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2020
@codecov-io
Copy link

codecov-io commented Jan 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2447ffc). Click here to learn what that means.
The diff coverage is 1.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10007   +/-   ##
=========================================
  Coverage          ?   43.59%           
=========================================
  Files             ?      588           
  Lines             ?    81257           
  Branches          ?        0           
=========================================
  Hits              ?    35420           
  Misses            ?    41454           
  Partials          ?     4383           
Impacted Files Coverage Δ
modules/repofiles/patch.go 0.00% <0.00%> (ø)
routers/api/v1/repo/patch.go 0.00% <0.00%> (ø)
routers/repo/patch.go 0.00% <0.00%> (ø)
routers/api/v1/api.go 75.39% <100.00%> (ø)
routers/routes/routes.go 86.60% <100.00%> (ø)
models/migrations/v105.go 0.00% <0.00%> (ø)
modules/queue/queue.go 24.44% <0.00%> (ø)
modules/process/manager.go 74.69% <0.00%> (ø)
modules/git/repo_hook.go 100.00% <0.00%> (ø)
models/helper_directory.go 40.90% <0.00%> (ø)
... and 583 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2447ffc...18824a5. Read the comment docs.

@6543
Copy link
Member

6543 commented Feb 14, 2020

add _diffpatch to the list of forbidden branchnames

@zeripath
Copy link
Contributor Author

@6543 I'm not sure banning _diffpatch is needed?

@lafriks
Copy link
Member

lafriks commented Feb 16, 2020

I also think it would not conflict with branch names

@stale
Copy link

stale bot commented Apr 16, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 16, 2020
@6543
Copy link
Member

6543 commented Apr 16, 2020

ping

@stale stale bot removed the issue/stale label Apr 16, 2020
@zeripath zeripath force-pushed the apply-patch branch 2 times, most recently from 2149ecd to 1664b3a Compare June 8, 2020 18:46
This code adds a simple endpoint to add diff patch application to Gitea
Signed-off-by: Andrew Thornton <art27@cantab.net>
@stale
Copy link

stale bot commented Aug 16, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 16, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 17, 2020
@stale stale bot removed the issue/stale label Aug 17, 2020
@binyamin
Copy link

@6543 My understanding is that #13442 (send patches via email) depends on this pull request. I'm looking forward to that feature. How can I help get this merged?

@zeripath
Copy link
Contributor Author

it's essentially ready depending on the UI but I was trying to get ```suggestion support sorted however I've been exceptionally busy fixing multiple bugs - (77 PRs to 1.14 fixing bugs)

@zeripath zeripath closed this Dec 3, 2021
@zeripath zeripath deleted the apply-patch branch December 3, 2021 19:50
@6543
Copy link
Member

6543 commented Dec 5, 2021

-> #17902

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants