Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Enhancement) Add "Review Required" Identifier on Pull Requests Targeting Protected Branches with Required Approvals #8257

Closed
2 of 7 tasks
bagasme opened this issue Sep 22, 2019 · 2 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@bagasme
Copy link
Contributor

bagasme commented Sep 22, 2019

  • Gitea version (or commit ref): 1.9.0
  • Git version: 2.17.1
  • Operating system: Ubuntu 18.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant (I couldn't access because of slow internet connection)
  • Log gist:
    (not relevant)

Description

In Pull Requests tab of Gitea repository, there isn't Review Required text next to who and when the pull request that merge into protected branch with required approvals setting was made. Thus, users don't know whether a PR requires reviews/approvals without having to click into individual PR link.

Screenshots

This screenshot below is from my localhost Gitea instance on my computer. I created learnPRHomework repository and set master branch protected with 1 required approval. Other user (bagas) open a pull request to this protected branch. Note that there isn't Review Required text as described in the description above:
Screenshot_2019-09-22 learnPRHomework

On the other hand, PR on GitHub with similar condition have Review Required text (the screenshot is from linode-docs PRs:
Screenshot_2019-09-22 linode docs

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Sep 22, 2019
@stale
Copy link

stale bot commented Nov 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Nov 21, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Nov 21, 2019
@stale stale bot removed the issue/stale label Nov 21, 2019
oscarcosta added a commit to oscarcosta/gitea that referenced this issue Dec 7, 2019
@6543
Copy link
Member

6543 commented Apr 26, 2020

I couldn't find the specific pull but its arlready implemented:

Bildschirmfoto zu 2020-04-26 15-59-36

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants