Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.9.0 breaks gogs web hooks #7692

Closed
2 of 7 tasks
UziTech opened this issue Jul 31, 2019 · 5 comments
Closed
2 of 7 tasks

1.9.0 breaks gogs web hooks #7692

UziTech opened this issue Jul 31, 2019 · 5 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone

Comments

@UziTech
Copy link

UziTech commented Jul 31, 2019

  • Gitea version (or commit ref): 1.9.0
  • Git version: 2.22.0.windows.1
  • Operating system: Windows
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

v1.9.0 changes the default web hook to use application/json so any existing Gogs web hook which was setup to receive application/x-www-form-urlencoded data will break because there is no place to change it in a Gogs web hook.

This is more of an FYI for anyone looking for a fix.

I fixed it by creating a Gitea web hook with the POST Content Type set to application/x-www-form-urlencoded

@lunny
Copy link
Member

lunny commented Aug 1, 2019

It seems it's a breaking change I haven't noticed.

@stale
Copy link

stale bot commented Sep 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Sep 30, 2019
@lunny lunny added the type/bug label Sep 30, 2019
@stale stale bot removed the issue/stale label Sep 30, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Sep 30, 2019
@lunny lunny mentioned this issue Oct 1, 2019
7 tasks
@lunny lunny added this to the 1.9.4 milestone Oct 1, 2019
@6543
Copy link
Member

6543 commented Oct 6, 2019

@aamsur this: #8402 should close this issue?

@lunny
Copy link
Member

lunny commented Oct 7, 2019

I think yes.

@lunny lunny closed this as completed Oct 7, 2019
@aamsur-mkt
Copy link

@6543 yes, thanks @lunny

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

No branches or pull requests

4 participants