Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-macaron/cache and go-macaron/session #7670

Closed
tamalsaha opened this issue Jul 30, 2019 · 10 comments · Fixed by #7933
Closed

Update go-macaron/cache and go-macaron/session #7670

tamalsaha opened this issue Jul 30, 2019 · 10 comments · Fixed by #7933

Comments

@tamalsaha
Copy link
Contributor

I would like to update the go-macaron/cache and go-macaron/session packages to use the latest version of go-redis client. The latest client has support for Redis cluster. I opened prs against the macaron repos for 2 months which have not been merged.

How can gitea use my updated version of the macaron libraries?

@techknowlogick
Copy link
Member

There has been some discussion on switching away from macaron due to several issues, one of which you mentioned (pending PRs not being merged for >2mos). The issue is #7403.

I think while we work on the above, we may need to fork macaron in the interim so we can add fixes, such as the ones above. Maybe we create a new org on gitea.com (we'd need to rename macaron to something else) with the macaron repos in it that Gitea project can maintain itself.

@lunny @zeripath thoughts?

@lunny
Copy link
Member

lunny commented Jul 30, 2019

I suggest we convert to gin web framework and we can maintain some gin's middlewares. I think we can do something on v1.10 and v1.11

@techknowlogick
Copy link
Member

I like gin, but that will take time to convert. I think short-term fork of macaron would be good while we wait for #7403

@lunny
Copy link
Member

lunny commented Jul 30, 2019

For a short-term target, I like your idea to create a new org in gitea.com to fork macaron's repositories.

@tamalsaha
Copy link
Contributor Author

I also agree with maintaining forked repos for now.

@lunny
Copy link
Member

lunny commented Jul 31, 2019

I have created fork organization https://gitea.com/macaron and I think we can move some gitea internal middlewares to that organization

tamalsaha added a commit to tamalsaha/gitea that referenced this issue Aug 1, 2019
Fix go-gitea#7670

Signed-off-by: Tamal Saha <tamal@appscode.com>
@tamalsaha
Copy link
Contributor Author

tamalsaha commented Aug 1, 2019

@techknowlogick / @lunny / @zeripath , it seems that the following macaron repos should be forked too, since the main macaron repo has been forked.

  • github.com/go-macaron/binding
  • github.com/go-macaron/cors
  • github.com/go-macaron/i18n
  • github.com/go-macaron/inject
  • github.com/go-macaron/toolbox

@lunny
Copy link
Member

lunny commented Aug 2, 2019

All above forked, but need PRs.

@tamalsaha
Copy link
Contributor Author

@lunny , can you please add drone for the repos? I can send pr for the go.mod stuff.

@lunny
Copy link
Member

lunny commented Aug 3, 2019

@tamalsaha all drone added.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants