Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit the history html 404 pushed by client #6809

Closed
6 tasks
ayanjoyful opened this issue Apr 30, 2019 · 4 comments · Fixed by #6842
Closed
6 tasks

Submit the history html 404 pushed by client #6809

ayanjoyful opened this issue Apr 30, 2019 · 4 comments · Fixed by #6842
Labels
type/bug
Milestone
1.8.1

Comments

@ayanjoyful
Copy link

  • Gitea version (or commit ref):
  • Git version:1.7.6
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • [*] MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

QQ图片20190430173321
As shown in figure:
The commit history in the red circle is from the client,Click on the error.Page 500.
Background the log Error Page 404
...

Screenshots
@lunny
Copy link
Member

lunny commented May 1, 2019

Could you confirm that v1.8.0 fix that?

@saitho
Copy link
Contributor

saitho commented May 1, 2019

Did you click on the commit hash or did you click on the commit message (7777777777)?
If latter one: that is because Gitea sees that as a possible SHA hash and links it to a commit.

Example on try.gitea.org (latest commit): https://try.gitea.io/saitho/test/commits/branch/test2

@mrsdizzie
Copy link
Member

For consistency we probably shouldn't render the commit Subject with the post processors so there aren't any autolink type things generated -- which means every Subject in that main list view will link to the actual commit without the chance that some link elsewhere.

Separate, this is probably another instance where if we checked if a hash existed first it wouldn't generate the link (though none of these subjects should end up links to elsewhere even if they are valid).

mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue May 3, 2019
@mrsdizzie
Don't post process commit summary in templates
a55aaaa 
Don't run summary through render/post process to avoid it generating
links and breaking certain views where the summary is already expected
to be a link to the commit. For consistancy, disable processing of
summary in all locations.

Fixes go-gitea#6809
@mrsdizzie mrsdizzie mentioned this issue May 3, 2019
Merged
techknowlogick pushed a commit that referenced this issue May 5, 2019
@mrsdizzie @techknowlogick
Don't post process commit summary in templates (#6842)
00b8838 
* Don't post process commit summary in templates

Don't run summary through render/post process to avoid it generating
links and breaking certain views where the summary is already expected
to be a link to the commit. For consistancy, disable processing of
summary in all locations.

Fixes #6809

* Do process title on diff page

On second thought, the title is often the only place a pull request
number will exists so do process it on the individual diff page. This
fixes the list view and still gives easy access to the PR link
@lunny
Copy link
Member

lunny commented May 6, 2019

It seems this should be backport to release/v1.8

@lunny lunny added this to the 1.8.1 milestone May 6, 2019
@mrsdizzie mrsdizzie mentioned this issue Jun 4, 2019
Closed
7 tasks
@lafriks lafriks mentioned this issue Jul 29, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.8.1
Development

Successfully merging a pull request may close this issue.

Don't post process commit summary in templates mrsdizzie/gitea
5 participants
@lunny @techknowlogick @mrsdizzie @saitho @ayanjoyful