Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request button on the pulls page does not behave the same as on the repo files page #6514

Closed
richmahn opened this issue Apr 4, 2019 · 0 comments
Labels
type/enhancement An improvement of existing functionality

Comments

@richmahn
Copy link
Contributor

richmahn commented Apr 4, 2019

Signaling intent to fix an issue we have been bothered by, where the link of the "New Pull Request" button on the Pull Request page of the upstream (main) repo will have the name of the user if the user has a fork of the repo. This should only happen if the user is on the Pull Request page of a fork, not all the time.

For example, user1 has repo1. user2 forks repo1 and thus has their own repo1. Go to user1/repo1's home page (file listing) and the "New Pull Request" button will be correct (http://localhost:3000/user1/repo1/compare/master...master)

Screen Shot 2019-04-04 at 4 01 04 PM

but if you go to the "Pull Requests" page, the link of the "New Pull Request" button is http://localhost:3000/user1/repo1/compare/master...user2:repo1

Screen Shot 2019-04-04 at 4 05 48 PM

This is not the desired use, nor like how GitHub works, as a user may very well be wanting to make a pull request from a branch of the current repo to the same repo (not from his/her repo). Users have to edit the URL themselves, and most of our users don't understand that.

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Apr 8, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants