Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitea shows an extra non-existing blank line at the end of every file #4050

Closed
2 of 7 tasks
ghost opened this issue May 26, 2018 · 0 comments · Fixed by #4054
Closed
2 of 7 tasks

Gitea shows an extra non-existing blank line at the end of every file #4050

ghost opened this issue May 26, 2018 · 0 comments · Fixed by #4054
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone

Comments

@ghost
Copy link

ghost commented May 26, 2018

  • Gitea version (or commit ref): 1.4.1 and 2eabf18 (try.gitea.io)
  • Git version: 1.4.1 built with: bindata, sqlite
  • Operating system: Debian Stretch
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (example URL in description)
    • No
    • Not relevant
  • Log gist:

Description

When viewing any file in the repository, it shows an extra, blank line at the end that shouldn't be there. When using the web editor to change the file, the additional blank line is also there.

Example

On GitLab the file is shown correctly, with 3 lines:
https://gitlab.com/higan/higan/blob/master/.gitignore

1  higan/profile/WonderSwan.sys/internal.ram
2  higan/profile/WonderSwan Color.sys/internal.ram
3  docs_build/

But on Gitea, the same file is shown incorrectly with 4 lines:
https://try.gitea.io/giteauser/example/src/branch/master/.gitignore

1  higan/profile/WonderSwan.sys/internal.ram
2  higan/profile/WonderSwan Color.sys/internal.ram
3  docs_build/
4

If you clone the repo from Gitea and open the file in vim, it correctly has 3 lines:

  1 higan/profile/WonderSwan.sys/internal.ram
  2 higan/profile/WonderSwan Color.sys/internal.ram
  3 docs_build/
~
~
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels May 26, 2018
axifive added a commit to axifive/gitea that referenced this issue May 27, 2018
Signed-off-by: Alexey Terentyev <axifnx@gmail.com>
@lunny lunny added this to the 1.5.0 milestone May 27, 2018
lunny pushed a commit that referenced this issue May 29, 2018
Signed-off-by: Alexey Terentyev <axifnx@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant