Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference issue from pull request #3134

Closed
svarlamov opened this issue Dec 10, 2017 · 13 comments · Fixed by #8137
Closed

Reference issue from pull request #3134

svarlamov opened this issue Dec 10, 2017 · 13 comments · Fixed by #8137
Assignees
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@svarlamov
Copy link
Contributor

  • Gitea version (or commit ref): 7ec6cdd

Description

When referencing an issue from a pull request description, ie., targeting #125 links properly, but when you're in the issue, there's no message saying that it was referenced in a pull request (such as Gitea does with commit messages or the way that Github does with pull request descriptions)

@svarlamov
Copy link
Contributor Author

Also, referencing an issue, ie., see #125 from an issue, links, but when you're in the referenced issue, there's no message about the reference -- as you would have in Github for instance

@lafriks
Copy link
Member

lafriks commented Dec 10, 2017

Can you create sample on try.gitea.io to demonstrate this problem

@svarlamov
Copy link
Contributor Author

@lafriks - sure!

Issue to issue ref:

1: https://try.gitea.io/svarlamov/sample-issues-3134/issues/1
2: https://try.gitea.io/svarlamov/sample-issues-3134/issues/2

2 references 1, but there's nothing in 1 to show that (as there would be for a commit msg)

PR to issue ref:

PR(a): https://try.gitea.io/svarlamov/sample-issues-3134/pulls/3
ISSUE(b): https://try.gitea.io/svarlamov/sample-issues-3134/issues/1

PR(a) references ISSUE(b), however, there's nothing to indicate that in ISSUE(b) -- as there otherwise would be for a commit msg

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 12, 2017
@lunny
Copy link
Member

lunny commented Dec 12, 2017

I think @svarlamov means reference comments.

@lunny lunny added this to the 1.x.x milestone Dec 12, 2017
@funkyfuture
Copy link

i think he means an information like the fourth under this comment in a pull request here.

@funkyfuture
Copy link

funkyfuture commented Jan 31, 2018

and like the one below that. :-)

@stevegt
Copy link
Contributor

stevegt commented Jun 23, 2018

I've created #4302 to address the case of the issue backlinks. I'm pretty sure PR backlinks (this issue) could use the same table discussed in #4302, if that turns out to be the solution.

@stale
Copy link

stale bot commented Jan 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 21, 2019
@AfroThundr3007730
Copy link

@lunny Perhaps the stale bot should be configured to ignore issues that are tracked in a milestone, or another tag could be created to exempt an issue from auto-closing.

It's not exactly ideal to keep bumping them manually.

@stale stale bot removed the issue/stale label Jan 21, 2019
@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 21, 2019
@lafriks
Copy link
Member

lafriks commented Jan 21, 2019

there is already label reviewed/confirmed that stalebot won't touch :)

@raucao
Copy link

raucao commented Jan 27, 2019

+1 for linking back to the PR from the issue view.

But also, it'd be nice to be able to close issues from PR descriptions. I.e. if the reference is "closes #123" it would close issue number 123 once the PR is merged (same as from commits). I do this all the time on GitHub and kind of miss it on Gitea now.

@guillep2k
Copy link
Member

This is pending. I'm interested in this feature, I might work on it next. Any caveats I should be aware of?

@worthy7
Copy link

worthy7 commented Sep 9, 2019

@skddc One thing at a time ;-) make a new issue on that one (It's probably somewhere already!) please

@guillep2k Thanks!

@lunny lunny modified the milestones: 1.x.x, 1.10.0 Sep 20, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants