Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo page still shows incorrect clone url under different domain names #29462

Closed
darkclip opened this issue Feb 28, 2024 · 8 comments · Fixed by #29470
Closed

repo page still shows incorrect clone url under different domain names #29462

darkclip opened this issue Feb 28, 2024 · 8 comments · Fixed by #29470
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.21.8

Comments

@darkclip
Copy link

Description

I reported this issue weeks ago, see #29084 , it was quickly patched and marked as fixed.
But after the merge of that patch, the bug is still there.

Gitea Version

1.21.7

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

wrong

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None
@ravensorb
Copy link

same is try for packages

@lunny
Copy link
Member

lunny commented Feb 28, 2024

I cannot reproduce it in my local both main and v1.21. How did you reproduce it on try site?

@lunny
Copy link
Member

lunny commented Feb 28, 2024

same is try for packages

Packages should be another issue.

@darkclip
Copy link
Author

I cannot reproduce it in my local both main and v1.21. How did you reproduce it on try site?

Just as I stated in the original issue report #29084, set ROOR_URL = https://git.aaa.com:8443/, then visit through https://git.bbb.com/.

@darkclip
Copy link
Author

I suspect it's because templates/repo/clone_script.tmp is not being set with url.port = window.location.port;.
But I'm not sure.

@wxiaoguang
Copy link
Contributor

Unfortunately , #29085 didn't fix the "clone_script.tmpl" .....

@silverwind would you like to take a look?

@wxiaoguang wxiaoguang added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 28, 2024
@silverwind
Copy link
Member

silverwind commented Feb 28, 2024 •
edited
Loading

Ah, I wasn't aware that clone_script was still a thing. I thought we had replaced it entirely with the <gitea-origin-url>, but apparently not and it's still in use for <input>. Yes it needs the same fix.

silverwind added a commit to silverwind/gitea that referenced this issue Feb 28, 2024
@silverwind
Fix URL calculation in clone input box
7174270 
Ported the function as-is and added comments so we don't forget about
this in the future.

Fixes: go-gitea#29462
@silverwind silverwind mentioned this issue Feb 28, 2024
Merged
@silverwind
Copy link
Member

#29470

silverwind added a commit to silverwind/gitea that referenced this issue Feb 28, 2024
@silverwind
Fix URL calculation in clone input box
7cd80e6 
Ported the function as-is and added comments so we don't forget about
this in the future.

Fixes: go-gitea#29462
silverwind added a commit to silverwind/gitea that referenced this issue Feb 28, 2024
@silverwind
Fix URL calculation in clone input box
ff37736 
Ported the function as-is and added comments so we don't forget about
this in the future.

Fixes: go-gitea#29462
jolheiser pushed a commit that referenced this issue Feb 28, 2024
@silverwind
Fix URL calculation in clone input box (#29470)
82405f8 
Ported the function as-is and added comments so we don't forget about
this in the future.

Fixes: #29462
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Feb 28, 2024
@silverwind @GiteaBot
Fix URL calculation in clone input box (go-gitea#29470)
4c579ea 
Ported the function as-is and added comments so we don't forget about
this in the future.

Fixes: go-gitea#29462
@GiteaBot GiteaBot mentioned this issue Feb 28, 2024
Merged
@lunny lunny added this to the 1.21.8 milestone Feb 28, 2024
jolheiser pushed a commit that referenced this issue Feb 28, 2024
@GiteaBot @silverwind
Fix URL calculation in clone input box (#29470) (#29473)
222f938 
Backport #29470 by @silverwind

Ported the function as-is and added comments so we don't forget about
this in the future.

Fixes: #29462

Co-authored-by: silverwind <me@silverwind.io>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 6, 2024
@silverwind @earl-warren
Fix URL calculation in clone input box (#29470)
6e89eff 
Ported the function as-is and added comments so we don't forget about
this in the future.

Fixes: go-gitea/gitea#29462
(cherry picked from commit 82405f808d7b50c3580f26e5ca645e2ed6d284ab)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 13, 2024
@GiteaBot @earl-warren
Fix URL calculation in clone input box (#29470) (#29473)
0b287c4 
Backport #29470 by @silverwind

Ported the function as-is and added comments so we don't forget about
this in the future.

Fixes: go-gitea/gitea#29462

Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit 222f93822eb4d03f5001ef665377a115bc27ccb6)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.21.8
Development

Successfully merging a pull request may close this issue.

Fix URL calculation in clone input box silverwind/gitea
5 participants
@lunny @silverwind @wxiaoguang @ravensorb @darkclip