Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error on action run page #27213

Closed
denyskon opened this issue Sep 23, 2023 · 7 comments · Fixed by #27289
Closed

JS error on action run page #27213

denyskon opened this issue Sep 23, 2023 · 7 comments · Fixed by #27289
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Milestone

Comments

@denyskon
Copy link
Member

Description

Bildschirmaufzeichnung.vom.2023-09-23.17-34-22.webm

Switching from an action run page to another page, an error appears saying JavaScript promise rejection: TypeError: t is undefined

Gitea Version

1.21.0-rc0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker-Compose

Database

SQLite

@denyskon denyskon added this to the 1.21.0 milestone Sep 23, 2023
@denyskon denyskon added the topic/gitea-actions related to the actions of Gitea label Sep 23, 2023
@lng2020
Copy link
Member

lng2020 commented Sep 25, 2023

Could you provide more detailed information in the Chrome dev console about where the error occurs?

@silverwind
Copy link
Member

silverwind commented Sep 25, 2023

Need a stack trace and/or screenshot of surrounding code in devtools. You will need to check "Preserve Log" in the devtools console so it persists across page reload:

image

BTW I fixed a similar bug in #26985, but I think this one is different.

@denyskon
Copy link
Member Author

grafik

That's everything I get. Do you have any other suggestions how to narrow it down?

@silverwind
Copy link
Member

Click on the index.js link top right, then find the button to pretty-print the source and screenshot that. From the stack trace I can see it happens in loadJob.

@wxiaoguang
Copy link
Contributor

BTW I fixed a similar bug in #26985, but I think this one is different.

Because #26985 has bug. You missed a return in the catch

@denyskon
Copy link
Member Author

grafik
Seems to be exactly where you introduced the fetch wrapper...

@silverwind
Copy link
Member

silverwind commented Sep 26, 2023

Oops, yes that should have a return. The error message is odd but I'm pretty sure the return will fix it and this is the effect of a network error you are seeing where the return value of those fetches is undefined because it threw. Not sure if I will be able to reproduce the exact error you had.

wxiaoguang pushed a commit that referenced this issue Sep 27, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Sep 27, 2023
lunny pushed a commit that referenced this issue Sep 27, 2023
Backport #27289 by @silverwind

Should fix: #27213

@denyskon can you test this? I can not reproduce this error locally.

Co-authored-by: silverwind <me@silverwind.io>
techknowlogick pushed a commit that referenced this issue Sep 27, 2023
Previously, the production build never output sourcemaps. Now we emit
one file for `index.js` because it is the most likely one where we need
to be able to better debug reported issues like
#27213. This will currently
increase the binary size of gitea by around 700kB which is what the
gzipped source map file has.

Also, I fixed the CSS sourcemap generation which was broken since the
introduction of lightningcss.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Sep 27, 2023
…tea#27291)

Previously, the production build never output sourcemaps. Now we emit
one file for `index.js` because it is the most likely one where we need
to be able to better debug reported issues like
go-gitea#27213. This will currently
increase the binary size of gitea by around 700kB which is what the
gzipped source map file has.

Also, I fixed the CSS sourcemap generation which was broken since the
introduction of lightningcss.
silverwind added a commit that referenced this issue Sep 27, 2023
… (#27295)

Backport #27291 by @silverwind

Previously, the production build never output sourcemaps. Now we emit
one file for `index.js` because it is the most likely one where we need
to be able to better debug reported issues like
#27213. This will currently
increase the binary size of gitea by around 700kB which is what the
gzipped source map file has.

Also, I fixed the CSS sourcemap generation which was broken since the
introduction of lightningcss.

The chinese docs are machine-translated, please correct accordingly.

Co-authored-by: silverwind <me@silverwind.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants