After update to version 1.20.0 Gitea refused to start

[veita]

Description

• Update from Gitea 1.19.4 to 1.20.0
• Gitea deployed as a Systemd service on Debian 12

Start with systemctl start gitea fails.

The log configured in app.ini does not give any hint about the cause of the error (neither did journalctl).

Starting Gitea interactively from the terminal revealed the cause:

$ GITEA_WORK_DIR=/var/lib/gitea/ /usr/local/bin/gitea web -c /etc/gitea/app.ini
2023/07/19 19:48:36 ...g/config_provider.go:327:deprecatedSettingFatal() [F] Deprecated fallback `[server]` `LFS_CONTENT_PATH` present. Use `[lfs]` `PATH` instead. This fallback will be/has been removed in v1.19.0

This information should probably also be written to configured log file. Also "v1.19.0" in the error message does not seem to be correct. And it may be added to the list of breaking changes (https://github.com/go-gitea/gitea/releases/tag/v1.20.0).

Gitea Version

1.20.0

Can you reproduce the bug on the Gitea demo site?

No

How are you running Gitea?

Download from GitHub; run as a Systemd service.

Database

PostgreSQL

[why0why0why]

Try to modify app.ini from

[server]
LFS_CONTENT_PATH=xxxxx

to

[lfs]
PATH=xxxxx

[veita]

@lunny This bug report is about missing log entries, incorrect information and the incomplete change log, which may prevent people from finding the configuration error easily.

This information should probably also be written to configured log file. Also "v1.19.0" in the error message does not seem to be correct. And it may be added to the list of breaking changes (https://github.com/go-gitea/gitea/releases/tag/v1.20.0).

[veita]

@why0why0why See https://docs.gitea.com/administration/git-lfs-setup

[DaveRabelink]

Be aware that you have to remove or comment (using ;) the old setting.
Even when the new setting is in place, Gitea will not start if the old setting is still there.
(which is a defect IMHO as it should ignore not used settings in all cases).

[Johnson90512]

Can this also be added to the upgrade documentation? I just ran into this issue while upgrading and took a lot of searching to find this post.

[jme147]

upgrade-from-gitea.en-us.md

[jme147]

I tried to create a pull request to update the installation/upgrade instructions, but couldn't create a request due to not being a collaborator. Can someone add the above file to a pull request?

[lunny]

Can this also be added to the upgrade documentation? I just ran into this issue while upgrading and took a lot of searching to find this post.

Reasonable. I think we can add a step for upgrade which is check your admin panel top bar. Some deprecated configurations will be displayed there, if you couldn't resolve them, Gitea may cannot started after upgrade. I will create a PR for that.