Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commits history page style error #25693

Closed
ExplodingDragon opened this issue Jul 5, 2023 · 5 comments · Fixed by #25710
Closed

commits history page style error #25693

ExplodingDragon opened this issue Jul 5, 2023 · 5 comments · Fixed by #25710
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself topic/ui Change the appearance of the Gitea UI type/bug

Comments

@ExplodingDragon
Copy link
Contributor

Description

No response

Screenshots

图片

Gitea Version

3dbcbf7

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

linux

Browser Version

firefox last stable
@ExplodingDragon ExplodingDragon added type/bug topic/ui Change the appearance of the Gitea UI labels Jul 5, 2023
@silverwind silverwind added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jul 5, 2023
@silverwind
Copy link
Member

silverwind commented Jul 5, 2023 •
edited
Loading

Example https://try.gitea.io/silverwind/symlink-test/commits/branch/master.

Seems like a recent regression, but at least not obvious. It looks like the table column does not have enough space. Maybe the content did grow?

@stuzer05
Copy link

stuzer05 commented Jul 5, 2023

Can confirm this issue
image

@lunny lunny added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Jul 5, 2023
@wxiaoguang
Copy link
Contributor

Because the "fixed" class was removed by #25634

Addeding the "fixed" back then the UI is right again.

image

@wxiaoguang wxiaoguang mentioned this issue Jul 5, 2023
Merged
@silverwind
Copy link
Member

@denyskon are you able to raise fix PR, and once merged, incorporate the change into #25689?

@denyskon
Copy link
Member

denyskon commented Jul 5, 2023

I will do it, give me an hour or so, not at home currently 🚉

@techknowlogick techknowlogick changed the title commits history page style error. commits history page style error Jul 5, 2023
@denyskon denyskon mentioned this issue Jul 5, 2023
Merged
6543 pushed a commit that referenced this issue Jul 6, 2023
@denyskon @silverwind
Fix commits table regression (#25710)
753755b 
Fixes #25693

The commits table appearance fix in #25634 was incomplete and caused a
regression. This PR fixes that issue and removes some unneeded CSS
classes because of the proper fix.

<details>
<summary>Before</summary>

![Bildschirmfoto vom 2023-07-05
19-37-04](https://github.com/go-gitea/gitea/assets/47871822/4f680878-9612-443b-a0a3-b331369c912b)
![Bildschirmfoto vom 2023-07-05
19-38-56](https://github.com/go-gitea/gitea/assets/47871822/8826f246-6bde-4c33-9d10-172d11619908)

</details>

<details>
<summary>After</summary>

![Bildschirmfoto vom 2023-07-05
19-37-44](https://github.com/go-gitea/gitea/assets/47871822/0fe2d2cb-f706-41e0-b341-d1827a64b21a)
![Bildschirmfoto vom 2023-07-05
19-38-08](https://github.com/go-gitea/gitea/assets/47871822/2f29271c-7da5-44d7-bd9a-38a4bfdde219)

</details>

---------

Co-authored-by: silverwind <me@silverwind.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix commits table regression denyskon/gitea
6 participants
@lunny @silverwind @wxiaoguang @stuzer05 @ExplodingDragon @denyskon