Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File tree wrong icon offset #25650

Closed
KN4CK3R opened this issue Jul 3, 2023 · 5 comments · Fixed by #26565
Closed

File tree wrong icon offset #25650

KN4CK3R opened this issue Jul 3, 2023 · 5 comments · Fixed by #26565
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@KN4CK3R
Copy link
Member

KN4CK3R commented Jul 3, 2023 •
edited
Loading

Description

The icon offset is different for files in dirs.

grafik

It only occurs when zooming in, 110% in my tests.
Example
@KN4CK3R KN4CK3R added type/bug topic/ui Change the appearance of the Gitea UI labels Jul 3, 2023
@wxiaoguang
Copy link
Contributor

That's a longstanding problem. I have spent a little time on it.

It's related to the path level (but not related to zoom level).

image

@silverwind
Copy link
Member

silverwind commented Jul 3, 2023 •
edited
Loading

IDK about this display: grid, but this case could may as well use display: flex with the link between icons with flex: 1. I'd say grid is better suited for 2-dimensional content, while flex is for 1-dimensional.

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Jul 3, 2023

It's related to the path level (but not related to zoom level).

On my end it's related to the zoom level:

100%
grafik

110%
grafik

@wxiaoguang
Copy link
Contributor

It's related to the path level (but not related to zoom level).

On my end it's related to the zoom level:

You can try to make some "deep" paths

@wxiaoguang wxiaoguang mentioned this issue Aug 17, 2023
Merged
@wxiaoguang
Copy link
Contributor

-> Rewrite the DiffFileTreeItem and fix misalignment #26565

silverwind pushed a commit that referenced this issue Aug 18, 2023
@wxiaoguang @delvh
Rewrite the DiffFileTreeItem and fix misalignment (#26565)
48c4a7e 
Fix some layout / user-interaction problems and close #25650 , the code
has been simplified (+46 −108)

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/55c38812-3338-4048-9137-0cae0ef213e8)

</details>

---------

Co-authored-by: delvh <dev.lh@web.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite the DiffFileTreeItem and fix misalignment wxiaoguang/gitea
3 participants
@silverwind @KN4CK3R @wxiaoguang